[4suite-checkins] [XML1_0-maint] In 4Suite/PC/build_scripts, files stubmain.c, stubres.rc

Jeremy Kloth jkloth at 4suite.org
Sun Nov 12 16:29:14 MST 2006


Branch: XML1_0-maint

Modified Files:
    stubmain.c stubres.rc

Log Message:
Fixed buffer overrun when executing script stubs.
ViewCVS diff:
  http://cvs.4suite.org/viewcvs/4Suite/PC/build_scripts/stubmain.c.diff?r1=1.1.2.3&r2=1.1.2.4
ViewCVS view:
  http://cvs.4suite.org/viewcvs/4Suite/PC/build_scripts/stubmain.c?rev=1.1.2.4&content-type=text/vnd.viewcvs-markup

Index: stubmain.c
===================================================================
RCS file: /var/local/cvsroot/4Suite/PC/build_scripts/stubmain.c,v
retrieving revision 1.1.2.3
retrieving revision 1.1.2.4
diff -U2 -r1.1.2.3 -r1.1.2.4
--- stubmain.c	30 Oct 2006 20:39:18 -0000	1.1.2.3
+++ stubmain.c	12 Nov 2006 23:29:14 -0000	1.1.2.4
@@ -153,5 +153,5 @@
     return NULL;
   }
-  lpScript = LocalAlloc(LMEM_FIXED, pScriptInfo->ScriptSize);
+  lpScript = LocalAlloc(LMEM_FIXED, pScriptInfo->ScriptSize + 1);
   if (lpScript == NULL) {
     CloseHandle(hFile);
ViewCVS diff:
  http://cvs.4suite.org/viewcvs/4Suite/PC/build_scripts/stubres.rc.diff?r1=1.1.2.2&r2=1.1.2.3
ViewCVS view:
  http://cvs.4suite.org/viewcvs/4Suite/PC/build_scripts/stubres.rc?rev=1.1.2.3&content-type=text/vnd.viewcvs-markup

Index: stubres.rc
===================================================================
RCS file: /var/local/cvsroot/4Suite/PC/build_scripts/stubres.rc,v
retrieving revision 1.1.2.2
retrieving revision 1.1.2.3
diff -U2 -r1.1.2.2 -r1.1.2.3
--- stubres.rc	24 Sep 2006 22:28:22 -0000	1.1.2.2
+++ stubres.rc	12 Nov 2006 23:29:14 -0000	1.1.2.3
@@ -7,7 +7,7 @@
 1 RCDATA
 {
-	0x00004654L,        // DWORD Signature
+    0x00005446L,        // DWORD Signature
     0x0000,             // WORD MajorPythonVersion
-	0x0000,             // WORD MinorPythonVersion
+    0x0000,             // WORD MinorPythonVersion
     0x0003,             // WORD Subsystem
     0x0000,             // WORD Characteristics
@@ -17,28 +17,28 @@
 
 1 VERSIONINFO
-   	FILEVERSION    1,0,0,1
-	PRODUCTVERSION 0,0,0,0
-	FILEOS         VOS__WINDOWS32
-	FILETYPE       VFT_APP
+    FILEVERSION    1,0,0,1
+    PRODUCTVERSION 0,0,0,0
+    FILEOS         VOS__WINDOWS32
+    FILETYPE       VFT_APP
 {
     BLOCK "StringFileInfo"
     {
-	    BLOCK "040904E4"
-	    {
-		    VALUE "Comments", "Python console application stub"
-    		VALUE "CompanyName", ""
-	    	VALUE "FileDescription", ""
-		    VALUE "FileVersion", "1.0.0.1"
-    		VALUE "InternalName", "stubmain.exe"
-	    	VALUE "LegalCopyright", ""
-		    //VALUE "LegalTrademarks", ""
-    		VALUE "OriginalFilename", "stubmain.exe"
-	    	VALUE "ProductName", "4Suite"
-		    VALUE "ProductVersion", "0.0.0.0"
-	    }
+        BLOCK "040904E4"
+        {
+            VALUE "Comments", "Python console application stub"
+            VALUE "CompanyName", ""
+            VALUE "FileDescription", ""
+            VALUE "FileVersion", "1.0.0.1"
+            VALUE "InternalName", "stubmain.exe"
+            VALUE "LegalCopyright", ""
+            //VALUE "LegalTrademarks", ""
+            VALUE "OriginalFilename", "stubmain.exe"
+            VALUE "ProductName", "4Suite"
+            VALUE "ProductVersion", "0.0.0.0"
+        }
     }
     BLOCK "VarFileInfo"
     {
-	    VALUE "Translation", 0x0409 0x04E4
+        VALUE "Translation", 0x0409 0x04E4
     }
 }


More information about the 4suite-checkins mailing list